pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
155 stars 24 forks source link

"Unknown specification for ssh_keys" on droplet_create #145

Closed trestletech closed 6 years ago

trestletech commented 6 years ago

Originally reported in https://github.com/trestletech/plumber/issues/224, but I've since been able to reproduce:

> d <- analogsea::droplet_create(image="ubuntu-16-04-x64")
Error: Unknown specification for ssh_keys
> 
> 
> d <- analogsea::droplet_create(image="ubuntu-16-04-x64", ssh_keys = NULL)
Using default ssh keys: ...

It looks like analogsea uses list() as the default for droplet_create, but NULL as the default for dropletS_create. The underlying SSH key function has special handling for NULL but not for empty lists. See

Perhaps droplet_create should default to NULL keys?

Session Info ```r > devtools::session_info() Session info ------------------------------------------------------------------------------------ setting value version R version 3.4.0 (2017-04-21) system x86_64, darwin15.6.0 ui RStudio (1.1.383) language (EN) collate en_US.UTF-8 tz America/Chicago date 2017-12-29 Packages ---------------------------------------------------------------------------------------- package * version date source analogsea 0.6.0 2017-12-29 Github (sckott/analogsea@a490938) aws.s3 0.3.3 2017-06-14 cran (@0.3.3) aws.signature 0.3.5 2017-07-01 cran (@0.3.5) base * 3.4.0 2017-04-21 local base64enc 0.1-3 2015-07-28 CRAN (R 3.4.0) compiler 3.4.0 2017-04-21 local curl 3.0 2017-10-06 cran (@3.0) datasets * 3.4.0 2017-04-21 local devtools 1.13.2 2017-06-02 CRAN (R 3.4.0) digest 0.6.13 2017-12-14 cran (@0.6.13) graphics * 3.4.0 2017-04-21 local grDevices * 3.4.0 2017-04-21 local httpuv 1.3.5 2017-07-04 cran (@1.3.5) httr 1.3.1 2017-08-20 cran (@1.3.1) jsonlite 1.5 2017-06-01 CRAN (R 3.4.0) magrittr 1.5 2014-11-22 CRAN (R 3.4.0) memoise 1.1.0 2017-04-21 CRAN (R 3.4.0) methods * 3.4.0 2017-04-21 local openssl 0.9.9 2017-11-10 cran (@0.9.9) R6 2.2.2 2017-06-17 cran (@2.2.2) Rcpp 0.12.12 2017-07-15 cran (@0.12.12) stats * 3.4.0 2017-04-21 local tools 3.4.0 2017-04-21 local utils * 3.4.0 2017-04-21 local withr 2.1.0 2017-11-01 cran (@2.1.0) xml2 1.1.1 2017-01-24 CRAN (R 3.4.0) yaml 2.1.16 2017-12-12 cran (@2.1.16) > ```
trestletech commented 6 years ago

Oops. Dup of #144.