pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
154 stars 24 forks source link

add keyfile parameter to droplet_ssh function #153

Closed rpodcast closed 6 years ago

rpodcast commented 6 years ago

Description

This PR adds a new parameter keyfile to the droplet_ssh function, which in turn is passed down to the do_ssh and ssh::ssh_connect functions. In this way if the user depends on utilizing a private SSH key to connect to their droplets from their local machine, they are able to do so.

Related Issue

143

Example

# assume user has private key stored in ~/.ssh/id_rsa_digitalocean
d <- droplet_create(region = "nyc3")
droplet_ssh(d, "date", keyfile = "~/.ssh/id_rsa_digitalocean")
sckott commented 6 years ago

thanks @thercast having a look

sckott commented 6 years ago

@jeroen while we're adding ability to pass in keyfile param, is there any reason to allow users to pass in the passwd parameter to ssh_connect in this package ?

jeroen commented 6 years ago

If the keyfile is password protected, or if the server requires password authentication, the user needs to supply a passphrase.

sckott commented 6 years ago

okay, thanks

sckott commented 6 years ago

@thercast seems like we also need to pass the passwd param, can you add that to this PR?

rpodcast commented 6 years ago

Sounds good I'll work on that when I get back to the computer

On Feb 9, 2018 6:05 PM, "Scott Chamberlain" notifications@github.com wrote:

@thercast https://github.com/thercast seems like we also need to pass the passwd param, can you add that to this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sckott/analogsea/pull/153#issuecomment-364595115, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_qpzCDB_c9Xe3iZEOzJDJiWXBBnot-ks5tTM9WgaJpZM4R_aXB .

rpodcast commented 6 years ago

@sckott I just pushed a commit with adding passwd to the function