search

pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
155 stars 24 forks source link

default password broken in docklet_rstudio #170

Closed nielsaka closed 5 years ago

nielsaka commented 6 years ago

Running the default example from the repository's README.md

docklet_create() %>%
  docklet_rstudio()

did not work out of the box. The browser opened but no connection was made. Apparently the containerized RStudio server rejects any passwords that are set to rstudio.

I found this out by loging into the droplet manually and starting the docker container, which gave

   ERROR: You must set a unique PASSWORD (not 'rstudio') first! e.g. run with:
docker run -e PASSWORD=<YOUR_PASS> -p 8787:8787 rocker/rstudio

Indeed, with a different password

docklet_create() %>%
  docklet_rstudio(password = "really_nice_r_package!")

it all works. I suggest modifying the default password here.

nielsaka commented 6 years ago

I would like to add that the broken password is actually desired behaviour from over here at rocker. They disliked the feature of a default password that too many people end up not changing.

Not sure if setting a new default password is a good response to their change.

sckott commented 6 years ago

thanks @nielsaka for raising this issue. having a look at the PR