search

pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
155 stars 24 forks source link

added passthrough options #199

Closed muschellij2 closed 3 years ago

muschellij2 commented 4 years ago

Added passthrough options for a keyfile, as requested in https://github.com/meztez/plumberDeploy/issues/12

Description

Now you can specify a keyfile for any operation that requires ssh. Related to https://github.com/sckott/analogsea/issues/155

Related Issue

https://github.com/sckott/analogsea/issues/155

sckott commented 4 years ago

thanks @muschellij2

sadly i still don't have tests for most things here. have you tested the added parameters yourself?

muschellij2 commented 4 years ago

@Adamoso - I made this to try to address your issue at https://github.com/rstudio/plumber/issues/524. Would you be able to test?

arydelek commented 4 years ago

Hello @muschellij2! Thank you for addressing this issue. I will test it and share my results here.

muschellij2 commented 3 years ago

Any thoughts on this? I think travis fails were due to DO tokens.

sckott commented 3 years ago

@muschellij2 are you asking me? or are you waiting on response from @Adamoso ?

muschellij2 commented 3 years ago

Apologies, asking from @Adamoso. Also, unsure if the failures are true or false positives, which I think @sckott can answer. Also, just seeing if you need additional tests for this. I don't pass in keyfiles or other params to use this, but I think it could be useful if you do.

arydelek commented 3 years ago

@muschellij2 sorry for taking so long! I was finally able to test most of the functionalities with two different keys. Everything seems to function properly. I can't however find any reason the tests are failing as when I was using the modified functions without specifying new parameters it seemed to work just the same as before.

sckott commented 3 years ago

tests failing b/c token not available in PR's

having a look

sckott commented 3 years ago

looks good to me