search

pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
155 stars 24 forks source link

Added keyfile option to docklet_shinyapp function a.o. #210

Closed pjastam closed 2 years ago

pjastam commented 2 years ago

The docklet_shinyapp function did not have a keyfile argument and assumed the default private keyname id_rsa. I added a keyfile argument to this function (and related functions) in order to be able to set non-default private keynames. I tested the new code locally and it worked for me. This may be interesting for others too :-)

pachadotdev commented 2 years ago

The docklet_shinyapp function did not have a keyfile argument and assumed the default private keyname id_rsa. I added a keyfile argument to this function (and related functions) in order to be able to set non-default private keynames. I tested the new code locally and it worked for me. This may be interesting for others too :-)

thanks a lot, and sorry for the slow reply I'll test it at some point during the weekend

pachadotdev commented 2 years ago

Looks fine to me!

@pjastam hi, can you please commit the suggestions I sent

pachadotdev commented 2 years ago

@pachadotdev hi, I committed your suggestions to the test-shinyapp branch in my fork of the original analogue repository. It looks like I cannot merge the 2 commits into pachadotdev:main from pjastam:test-shinyapp, because I do not have write access I suppose? Any help would be greatly appreciated :-)

thanks! there's a problem with the CI that I won't be able to fix until 10-15 days from now, when it's fixed I'll merge

pachadotdev commented 2 years ago

I had to close the PR because my suggestions were not merged. I ended up implemented the idea that you described. As constructive feedback, this is a good idea but the indentation changes made it really hard to see the actual changes.