search

pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
154 stars 24 forks source link

analogsea::spaces doesn't return a list of spaces #214

Open krose opened 2 years ago

krose commented 2 years ago

This seems to be caused by a bug in aws.s3, but there seems to be a discussion going on if to use aws.s3 or not. The repo for aws.s3 doesn't seem to be updated with a lot of hanging pull requests, so I'll post the bug here. I hope this is fine.

There are two issues.

One concerning the aws.s3:::parse_aws_s3_response that checks for a content type (ctype) that doesn't match the way the API returns the xml type.

The other issue is with this if statement in the spaces function: if (identical(names(res$Buckets), c("Name", "CreationDate"))) { ... }. In the list the names are reversed compared to the test.

It seems to be two easy fixes, but the lack of development on the aws.s3 makes me hesitant to do a pull request.

pachadotdev commented 2 years ago

thanks, @krose I can move the functions I use from aws.s3 here

krose commented 2 years ago

That would be awesome. I'm planning to build some stuff around spaces, so let me know if you need help.

pachadotdev commented 2 years ago

all contributions are welcome, @krose at the moment, I need to close #185 first, or move it for later

pachadotdev commented 8 months ago

@krose Hi! Did you build some stuff around spaces? It would be great to see it

krose commented 8 months ago

Sadly not. I ended up doing system calls to their cli. I was under a lot of pressure to get it working fast.