Cleanly separate low level and high level API

[hadley]

It feels like analogsea is currently fighting to be two things: both a low-level and a high-level wrapper. I'd recommend making this distinction more clear - for example, I'd rewrite droplet_power_cycle as:

do_power_cycle <- function(id, config) {
  stopifnot(as.numeric(id), length(id) == 1)
  do_POST(what, 
    path = sprintf('droplets/%s/actions', id), 
    args = list(type = 'power_cycle'), 
    config = config
  )
}

as_power_cyle <- function(x, ...) {
  x <- as.droplet(x)

  res <- do_power_cycle(x$id, ...)
  x
}

• I've used do_ (for digital ocean) and as_ (for analogsea) to distinguish the low-level and high-level apis. Obviously you'd want to think about that - I think droplets_ is a bit long as a prefix (but it's not too bad)
• The high level api now becomes a thin wrapper around the low-level. I'd argue that the high-level wrappers should almost always return a droplet object to make it easier to chain. If you want other stuff you can always use the low-level api (so you no longer need the what argument).
• I suspect the print.droplet() method should do an API call to get up-to-date status

• It looks like the majority of functions in droplets.R could use a common low-level function:

  do_action <- function(id, action, config) {
  stopifnot(as.numeric(id), length(id) == 1)
  do_POST(what, 
    path = sprintf('droplets/%s/actions', id), 
    args = list(type = 'action'), 
    config = config
  )
  }

  (It might also make sense to document all these function in one file since their interface is identical)

I'd be happy to make these changes if they seemed ok to you.

[sckott]

@hadley I like the proposed distinction between low and high level.

• I wonder if the as_ should be an_ though, since perhaps users may assume a function starting with as_ is coercing an object to the suffix of that function name?
• I agree that the print method should get an up to date status for the droplet
• Agreed, documenting in single file is a good idea..
• Please do make the changes if you have time!

[hadley]

@sckott Agreed that an_ is better, but maybe it's better still to stick with the existing convention and use droplet_, image_ etc.

Would you mind adding me as a admin? I'm happy to make changes in a branch and submit pull requests if you want.

[sckott]

Added as collab.

No strong feeling on the prefixes

[hadley]

This is basically done now.