search

pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
155 stars 24 forks source link

Update tests #40

Closed sckott closed 10 years ago

sckott commented 10 years ago

I'll update tests that have old code in them.

@hadley Do you think there is a better way to do auth for the tests?

hadley commented 10 years ago

@sckott yes - I think it's better to use envar DO_PAT and only fall back to OAuth if that isn't available. Then you can rely on individuals having that set. (And you can set encrypted env var for travis etc)

sckott commented 10 years ago

Okay. Sorry about the poor state of the tests, I was assuming it was mostly just me using this, so I didn't put the time in on tests.

hadley commented 10 years ago

Could you please create a PAT, then add as an encrypted environment variable in travis? (Let me know if you need more instructions than that)

sckott commented 10 years ago

@hadley Okay, added a PAT to the settings for the repo in Travis, following http://docs.travis-ci.com/user/environment-variables/#Where-to-define-variables , done in the repository settings, instead of the .travis.yml file

hadley commented 10 years ago

Any reason you did it in the repo settings rather than in .travis.yml?

sckott commented 10 years ago

From that page, it seemed to make more sense to do it in the repo, but I'll do it in the travis file instead

hadley commented 10 years ago

Lets close this, and new tests as we discover bugs.