pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
154 stars 24 forks source link

Vignettes #74

Closed sckott closed 7 years ago

sckott commented 9 years ago
hadley commented 9 years ago

Definitely need a section on security that describes the defaults, and our motivation for them.

sckott commented 9 years ago

@hadley :+1:

sckott commented 9 years ago

I think it makes sense to include pre-rendered vignettes in vignettes/ since it requires auth to run, Make sense?

hadley commented 9 years ago

I think putting a pre-rendered vignette into vignettes/ is going to open you up to a world of hurt with R CMD check

sckott commented 9 years ago

@hadley I don't see why? Assuming you're right, what's the alternative when compiling the vignette requires authentication? Sure, we can do that locally, but how does that work on CRAN?

hadley commented 9 years ago

CRAN never builds vignettes

hadley commented 9 years ago

I guess it does run the code in them, but you can suppress that with a "no_tangle" knitr builder.

sckott commented 9 years ago

So with "no_tangle" code won't be run on CRAN, but will build (unless user suppresses) on installation?

hadley commented 9 years ago

install_github() now sets build_vignettes = FALSE by default, and vignettes are pre-built when you install from CRAN.