pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
154 stars 24 forks source link

Should regions, sizes, images etc be prefixed with droplet? #75

Closed hadley closed 9 years ago

sckott commented 9 years ago

I think probably not. We have droplet_* functions to do something with a droplet, and docklet_* to do something with a docker droplet.

regions, sizes, and images aren't specific to a particular droplet.

Is there other reasoning I'm missing?

hadley commented 9 years ago

I think the main thing is that it makes the code a bit harder to read because images(), regions(), keys() etc are so generic - there's nothing to key my brain into the fact that they're analogsea functions.

But maybe that's because I'm still getting used to my new approach to importing functions - I just need to remember that any bare function name is either in base R or in the current package.

sckott commented 9 years ago

Right, we've taken to prefixing fxns in some of our packages to help with this, even just a few letters like we could do an_<function name> for analogsea - or would the be more confusing