search

pachli / pachli-android

The Pachli Android app
https://pachli.app
GNU General Public License v3.0
132 stars 15 forks source link

fix: Ensure clientId and clientSecret are non null during db migration #1103

Closed nikclayton closed 1 week ago

nikclayton commented 1 week ago

Previous migration code could crash if the clientId or clientSecret columns were null during the migration (unclear how that could happen but there's at least one user report of this crash).

Re-write the migration to set these columns to the empty string if NULL first.

nikclayton commented 1 week ago

/apk

github-actions[bot] commented 1 week ago

Workflow Build and sign APK for PR: succeeded ✅ Results: https://github.com/pachli/pachli-android/actions/runs/11854828191 APK: https://github.com/pachli/pachli-android/actions/runs/11854828191/artifacts/2192503306

vinzv commented 1 week ago

Wanted to try the APK, but somehow I run into a 404.

nikclayton commented 1 week ago

Weird. Which link? https://github.com/pachli/pachli-android/actions/runs/11854828191/artifacts/2192503306 prompts me to download the apk.

vinzv commented 1 week ago

Oh wow, one needs to be logged in at the browser as well. Using the mobile GitHub app being logged in is not enough.

Anyway, removed the installed one and installed the APK. Now Pachli Current works again! 👍