search

pachli / pachli-android

The Pachli Android app
https://pachli.app
GNU General Public License v3.0
124 stars 15 forks source link

Crashing on GrapheneOS 14 #562

Open gvansanden opened 7 months ago

gvansanden commented 7 months ago

Describe the bug App started crashing constantly on GrapheneOS 14

To Reproduce Steps to reproduce the behavior:

  1. Browse the timeline for a couple of seconds to me nutes

Expected behavior App crashes and closes

Versions Pachli 2.3.0 Pleroma 2.7.2 Google Pixel 7 Android version: 14 SDK level: 34

Affirmation I have checked other issues for this project (open and closed) and I cannot find one that matches the problem I am reporting.

gvansanden commented 7 months ago

I just checked release dates and it is very possible this started with 2.3. I used pathcli for a while on this device without such issues.

nikclayton commented 7 months ago

Hi, thanks for the report, and sorry about the crashes.

Are you able to install Pachli Current, https://play.google.com/store/apps/details?id=app.pachli.current ?

If you are, that will help see if the problem is already fixed there. It also contains additional bug reporting features, allowing you to e-mail a crash report that will be very helpful for debugging.

What server is this happening with?

gvansanden commented 7 months ago

If you link me an apk I can upgrade. I installed from F-droid.

I use it with my own Pleroma server rebelbase.site, it used to work fine

22 Mar 2024 22:06:51 Nik Clayton @.***>:

Hi, thanks for the report, and sorry about the crashes.

Are you able to install Pachli Current, https://play.google.com/store/apps/details?id=app.pachli.current ?

If you are, that will help see if the problem is already fixed there. It also contains additional bug reporting features, allowing you to e-mail a crash report that will be very helpful for debugging.

What server is this happening with?

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2015918426], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFMDRSQJFD3FMUYOW73YZSMOFAVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHEYTQNBSGY]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AANORFN4IAUIVOCBBORP4QLYZSMOFA5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYFB4VU.gif]

nikclayton commented 7 months ago

There's an apk in the "artifacts" section of https://github.com/pachli/pachli-android/actions/runs/8382516111

That should trigger a crash report dialog that will let you email details, including a log.

gvansanden commented 7 months ago

It is installed, will try it for a bit but it hasn't crashed on first use yet...

22 Mar 2024 23:27:50 Nik Clayton @.***>:

There's an apk in the "artifacts" section of https://github.com/pachli/pachli-android/actions/runs/8382516111

That should trigger a crash report dialog that will let you email details, including a log.

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2016024872], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFKXGUBGSHQMNLMBTG3YZSV53AVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGAZDIOBXGI]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AANORFNY7T7WARTXBGYAHELYZSV53A5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYFIMSQ.gif]

gvansanden commented 7 months ago

It worked fine until now but the crashes started and won't stop. Report send

23 Mar 2024 08:56:17 Guy Van Sanden @.***>:

It is installed, will try it for a bit but it hasn't crashed on first use yet...

22 Mar 2024 23:27:50 Nik Clayton @.***>:

There's an apk in the "artifacts" section of https://github.com/pachli/pachli-android/actions/runs/8382516111

That should trigger a crash report dialog that will let you email details, including a log.

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2016024872], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFKXGUBGSHQMNLMBTG3YZSV53AVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGAZDIOBXGI]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AANORFNY7T7WARTXBGYAHELYZSV53A5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYFIMSQ.gif]

nikclayton commented 7 months ago

Thanks, the report has shown the problem.

03-23 20:52:15.447 E/ACRA ( 8608): ACRA caught a JsonDataException for app.pachli.current
03-23 20:52:15.447 E/ACRA ( 8608): com.squareup.moshi.JsonDataException: Not an RFC 3339 date:

Your server is returning badly formatted data. I've found similar problem in Friendica (https://github.com/friendica/friendica/issues/13986) and I know Pleroma has some problems here (https://git.pleroma.social/dashboard/issues?sort=created_date&state=opened&author_username=nikclayton) but I've not seen this specific one before.

I've got a fix that should prevent the crash and show more data that can be passed to the Pleroma devs so they can fix this. Please can you try the APK linked to from https://github.com/pachli/pachli-android/pull/565#issuecomment-2016803095. That should show an error message with more details about where the problem is. If you can follow up here with the precise error message we'll be able to dig a bit further.

As I say, it won't crash, but you'll probably see that error constantly until the post that has the problem disappears from your home timeline.

gvansanden commented 7 months ago

Installed, will let you know. Interesting though, my Pleroma server hasn't upgraded in a while and I used Patchli for weeks or longer without problems, this started showing up out of the blue.  It could be after the 2.3 release but not sure

24 Mar 2024 14:09:29 Nik Clayton @.***>:

Thanks, the report has shown the problem.

03-23 20:52:15.447 E/ACRA ( 8608): ACRA caught a JsonDataException for app.pachli.current 03-23 20:52:15.447 E/ACRA ( 8608): com.squareup.moshi.JsonDataException: Not an RFC 3339 date: Your server is returning badly formatted data. I've found similar problem in Friendica (friendica/friendica#13986[https://github.com/friendica/friendica/issues/13986]) and I know Pleroma has some problems here (https://git.pleroma.social/dashboard/issues?sort=created_date&state=opened&author_username=nikclayton) but I've not seen this specific one before.

I've got a fix that should prevent the crash and show more data that can be passed to the Pleroma devs so they can fix this. Please can you try the APK linked to from #565 (comment)[https://github.com/pachli/pachli-android/pull/565#issuecomment-2016803095]. That should show an error message with more details about where the problem is. If you can follow up here with the precise error message we'll be able to dig a bit further.

As I say, it won't crash, but you'll probably see that error constantly until the post that has the problem disappears from your home timeline.

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2016804814], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFMVXX7PPJPBBVIRN5TYZ3GADAVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHAYDIOBRGQ]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AANORFPDNNJBT75643GSZE3YZ3GADA5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYGX744.gif]

nikclayton commented 7 months ago

Thanks -- I just signed up for an account on rebelbase.site (account: pachli_test) to see if I can trigger the issue myself.

2.3.0 is stricter about how it processes the data it receives from a server. This has helped uncover a lot of server bugs, but it does introduce problems like these. I wrote more about this in the release post for 2.3.0, https://pachli.app/pachli/2024/02/28/2.3.0-release.html.

gvansanden commented 7 months ago

I approved your account

24 Mar 2024 14:34:44 Nik Clayton @.***>:

Thanks -- I just signed up for an account on rebelbase.site (account: pachli_test) to see if I can trigger the issue myself.

2.3.0 is stricter about how it processes the data it receives from a server. This has helped uncover a lot of server bugs, but it does introduce problems like these. I wrote more about this in the release post for 2.3.0, https://pachli.app/pachli/2024/02/28/2.3.0-release.html.

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2016811906], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFNF7ZCQUGIGZR35QEDYZ3I63AVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHAYTCOJQGY]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AANORFJHIUOYAPXJVA2BFUTYZ3I63A5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYGYNYE.gif]

nikclayton commented 7 months ago

Thanks, triggered it pretty quickly. It's similar to https://github.com/friendica/friendica/issues/13986.

I've reported this to the Pleroma devs at https://git.pleroma.social/pleroma/pleroma/-/issues/3261, and will work on a fix to prevent the crash.

nikclayton commented 7 months ago

@gvansanden Unrelated to the JSON issue there's something else odd about how rebelbase.site is configured.

When I set up the test account I didn't set an avatar.

This causes rebelbase.site to set the avatar to the URL "https://rebelbase.site/images/avi.png"

However, that is not an image -- if you fetch that URL it opens the site's login page. Not sure where in your configuration you'll need to look to fix that, but you should probably look in to it.

gvansanden commented 7 months ago

Thanks for following up on that. I will see if I can find why this happens...

24 Mar 2024 18:33:53 Nik Clayton @.***>:

@gvansanden[https://github.com/gvansanden] Unrelated to the JSON issue there's something else odd about how rebelbase.site is configured.

When I set up the test account I didn't set an avatar.

This causes rebelbase.site to set the avatar to the URL "https://rebelbase.site/images/avi.png"

However, that is not an image -- if you fetch that URL it opens the site's login page. Not sure where in your configuration you'll need to look to fix that, but you should probably look in to it.

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2016880579], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFN543SLQ6XTMWW2LKTYZ4E73AVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHA4DANJXHE]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/AANORFLWWSLM7QHSCVXLHQTYZ4E73A5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYG4T4G.gif]

nikclayton commented 7 months ago

If you install the APK artifact from https://github.com/pachli/pachli-android/actions/runs/8411821101 you should see the problem is resolved. Can you confirm that it is for you? Thanks.

gvansanden commented 7 months ago

I have no more crashes with that version, thank you very much!

nikclayton commented 7 months ago

@gvansanden FYI, the version of Pachli Current you installed to test this will not prompt you for updates, so now you're done testing I recommend removing it and either using Pachli (regular) or switching to Pachli Current from Google Play, which will prompt you to keep up to date.

gvansanden commented 7 months ago

Thank you. I will remove it when I have a new ons from F-droid.

28 Mar 2024 23:56:53 Nik Clayton @.***>:

@gvansanden[https://github.com/gvansanden] FYI, the version of Pachli Current you installed to test this /will not prompt you for updates/, so now you're done testing I recommend removing it and either using Pachli (regular) or switching to Pachli Current from Google Play, which will prompt you to keep up to date.

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2026276744], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFIRP36O72ZNMM4BSMTY2SG2FAVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGI3TMNZUGQ]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/AANORFMZ2GYWBQ3IMDBJM63Y2SG2FA5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYY2DYQ.gif]

gvansanden commented 6 months ago

Hi, I thought this was ok, but it seems that while Patchli does not crash and displays an error, it stops loading further posts. Meaning that if the top post has an invalid date, I can't further read the timeline. Can you take another look?

nikclayton commented 6 months ago

Can you send a link to the post that causes the problem?

gvansanden commented 6 months ago

It just gives the rfc date error and stops loading posts, but no link to which caused it...

30 Apr 2024 17:14:06 Nik Clayton @.***>:

Can you send a link to the post that causes the problem?

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2085612166], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFPZANYBJNP6IVFA2GTY76YLNAVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVGYYTEMJWGY]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/AANORFN6IC2MVVK7M6YP5KTY76YLNA5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT4J7VIM.gif]

nikclayton commented 6 months ago

When that happens, in Pachli Current the top-right three-dot menu has a "Send error report" item. Can you use that, and it should include a log that points to the error.

gvansanden commented 5 months ago

I send the report. It stops loading after the rfc error on a single post

nikclayton commented 5 months ago

Thanks, that was enough. I've just filed https://git.pleroma.social/pleroma/pleroma/-/issues/3268. Looks like I'll have to write a more lenient date parser as well.

Unfortunately I'll be on vacation in a few days for a couple of weeks, so I won't be able to get to this before then. Thanks for helping to troubleshoot this this far.

gvansanden commented 5 months ago

Enjoy the vacation and thank you for your responsiveness !

03 May 2024 17:35:36 Nik Clayton @.***>:

Thanks, that was enough. I've just filed https://git.pleroma.social/pleroma/pleroma/-/issues/3268. Looks like I'll have to write a more lenient date parser as well.

Unfortunately I'll be on vacation in a few days for a couple of weeks, so I won't be able to get to this before then. Thanks for helping to troubleshoot this this far.

— Reply to this email directly, view it on GitHub[https://github.com/pachli/pachli-android/issues/562#issuecomment-2093257479], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AANORFNIV6L2LYFGQMSI3CLZAOVD7AVCNFSM6AAAAABFD5I2LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGI2TONBXHE]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/AANORFLVEQKFHXEGZE5QY5LZAOVD7A5CNFSM6AAAAABFD5I2LGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT4YSJQO.gif]

gvansanden commented 2 months ago

Hi Nik, This issue is still there. so to recap, Pachli gives an error on faulty posts but it also stops loading subsequent posts, so the timeline stops there. If the first post is broken, There is no browsable timeline