search

pachli / pachli-android

The Pachli Android app
https://pachli.app
GNU General Public License v3.0
125 stars 15 forks source link

Video playback dimmed at beginning #873

Open Jasdemi opened 2 months ago

Jasdemi commented 2 months ago

Describe the bug Videos playback is dimmed for the first ~2 seconds. Making it hard to see.

To Reproduce Steps to reproduce the behavior:

  1. Watch any video.

Expected behavior No dimming. Keep the brightness the the same throughout the video.

Screenshots or video

https://github.com/user-attachments/assets/a75e58e8-0537-472a-bae4-c2a08e0c7e0a

Versions Pachli: 2.7.1 Server: GTS 0.16.1 Android: 14

Affirmation I have checked other issues for this project (open and closed) and I cannot find one that matches the problem I am reporting.

nikclayton commented 2 months ago

The dimming is to ensure that the playback controls, and any caption text, is visible when playback starts.

If the first few seconds of the video were very bright the controls and caption would be difficult to see.

Jasdemi commented 2 months ago

If this is an accessibility thing, can we get a toggle to turn it on/off? The dimming is really annoying, especially for short videos. I often have to rewatch it because barely see anything at the beginning.

I tried various android apps and video websites and Pachli is the only one doing it this way.

nikclayton commented 2 months ago

WhatsApp does this similar when it plays videos, although the scrim is limited to the areas with the controls and the text. The scrim is only visible for perhaps half a second as well.

When I was testing half a second often wasn't sufficient, because people would write longer captions for their media, and it would disappear in the middle of reading it.

I'll make a note to try and adjust the scrim area so it's controls and caption only, and not the entire video.