pachoning / bigmds

Other
15 stars 2 forks source link

Custom distance functions no longer supported? #4

Open rabdill opened 6 months ago

rabdill commented 6 months ago

Hello! bigmds has been very helpful in my research, and I was enthusiastic to start using the new version. However, it looks like the dist_fn parameter has been removed from all the places where it used to be an option. This makes my current analysis much more complicated, as it appears the only option now is Euclidean distance. I could be wrong about this, but the change isn't noted in the news file or described in the commit where it was changed, so would you mind clarifying the situation for those who need to use other distance measures to generate their MDS plots? Is it safe for me to use the previous version of the package that still had this option, or does the change address a bug I should try to avoid? Thanks for your help, and for putting together such a helpful package.

pachoning commented 6 months ago

Hi @rabdill , first of all, sorry for not making this huge change clearer. We had to get rid of the dist_fn parameter because a major review in our scientific paper forced us to do it. Said so, let me clarify some things:

I am gonna keep this issue open so that I can address it as soon as possible.

rabdill commented 6 months ago

Thanks for such a quick response, and I'm sorry you're dealing with a frustrating situation. There is no need to rush on my account—it's good to know the v2.0.1 code is still safe to use in the meantime. Best of luck in the review process!

dylanbeaudette commented 2 months ago

Hi, thanks for this amazing package. I too would like to request that the dist_fn option be added back to the functions. I deal with specialized distance metrics far more frequently than Euclidean distance.

pachoning commented 2 months ago

Hi @dylanbeaudette and @rabdill , I know having back thedist_fn would be great. I am about to finish the PhD. As soon as I get some free time, I will add it back for sure.

dylanbeaudette commented 2 months ago

Good luck with the Ph.D!