pachterlab / kb_python

A wrapper for the kallisto | bustools workflow for single-cell RNA-seq pre-processing
https://www.kallistobus.tools/
BSD 2-Clause "Simplified" License
141 stars 24 forks source link

Added flags to create genomebam file with kallisto bus #184

Closed ricomnl closed 1 year ago

ricomnl commented 1 year ago

kallisto bus has the following optional options:

--genomebam               Project pseudoalignments to genome sorted BAM file
-g, --gtf                     GTF file for transcriptome information
                              (required for --genomebam)
-c, --chromosomes             Tab separated file with chromosome names and lengths
                              (optional for --genomebam, but recommended)

This PR adds parameters to kb count so that one can use the --genomebam flag as well as a gtf file and optionally a chromosomes file to output a .bam file. A test is added to make sure the functionality works as intended.

ricomnl commented 1 year ago

@sbooeshaghi @Lioscro this would be a useful addition IMO because BAM files are required for downstream tasks like genetic demultiplexing. Right now, one would have to use cellranger to get bam files. In addition, the PR would solve this previous issue https://github.com/pachterlab/kb_python/issues/147

Yenaled commented 1 year ago

@ricomnl I am the person currently making major upgrades to and maintaining kallisto. Thanks for the pull request. I have several updates I need to make first but I will try to merge this pull request when I can. Don't worry -- it's on my radar.

Lioscro commented 1 year ago

As long as the commands printed from --dry-run looks reasonable, the changes lgtm.

Yenaled commented 1 year ago

@Lioscro all looks good to me; feel free to merge