Closed andrei-stoica26 closed 1 year ago
@Lioscro in ngs-tools, there were some previous commits in devel (when adding spatial chemistries) that occurred after the tagged v1.8.1 release that's causing errors to be thrown for v1.8.2 of ngs-tools.
Specifically in ngs_tools/chemistry/__init__.py
, there were some checks introduced for cleaning up chemistry names and extracting chemistry versions that's causing issues.
We have: if cleaned_name in base_name and cleaned_version == version
, however, if we get cleaned_name=10x (with cleaned_version=1), that will match multiple technologies' base_names (10xATAC, 10xFB, etc. [all of which are also defaulted to version=1]).
I think we should simply be checking if cleaned_name == base_name and cleaned_version == version
instead (i.e. ==
instead of in
).
Thanks for reporting this! I've yanked the release from Pypi. I'll make a patch with the fix.
Thank you for your help, it works well now with the new ngs-tools patch.
Hi,
I just installed kb-python and I am getting the following error when running kb:
Any ideas about how to fix this? Thank you for your help.