pachterlab / kma

Keep Me Around: Intron Retention Detection
GNU General Public License v2.0
29 stars 20 forks source link

inner_join in newIntronRetention #11

Open aldojongejan opened 7 years ago

aldojongejan commented 7 years ago

Dear all,

I had an issue with this function ('newIntronRetention') as I encountered the following error: Error in Ops.data.frame(numExp, denomExp) : ‘/’ only defined for equally-sized data frames which seems to be caused by 'retentionExp <- numExp/denomExp' in the function. The data.tables numExp and denomExp are not of the same dimension. As numExp is derived from denomExp, I traced it back to the use of an 'inner_join' in the creation of numExp: numExp <- select(denomExp, intron, intron_extension) %>% inner_join(tmp_targExpression, by = c("intron_extension")) %>% arrange(intron_extension)

Replacing the 'inner_join' by a 'left_join' solves the issue. But is this correct??

with kind regards, Aldo