pachterlab / kma

Keep Me Around: Intron Retention Detection
GNU General Public License v2.0
29 stars 20 forks source link

Error in "newIntronRetention" #19

Open adamtongji opened 5 years ago

adamtongji commented 5 years ago

Hi, when I run "newIntronRention", an error was shown as:

`summarise_each()` is deprecated.
Use `summarise_all()`, `summarise_at()` or `summarise_if()` instead.
To map `funs` over a selection of variables, use `summarise_at()`
Error in summarise_impl(.data, dots) : 
  Evaluation error: invalid 'type' (character) of argument

My R version is 3.4.1 on MacOS system. Thanks for your attention!

edkonyakhina commented 5 years ago

Hello, @adamtongji ! I have the same problem. If you find any solution, please let me know!

adamtongji commented 5 years ago

@edkonyakhina I made own minor revision to my forked github folder. And it is now work on sample data.
You can test the revised version by:

devtools::install_github("adamtongji/kma")
library(kma)

and run the tutorial code on example data or your own data.

The main reason for this bug might be some changes in newer version of package "dplyr". It would be better if the author can provide a conda or docker version of "kma" or revise it to support latest version of "dplyr".

Hope it would be work for you.

edkonyakhina commented 5 years ago

@adamtongji Thank you for you help! Now it works well!

zhengjiantao commented 5 years ago

@adamtongji 你好,你是不是把newIntronRetention函数里的所有left_join换成了merge?这样换对结果会有影响吗? 另外,我导入你修改的KMA后,numerator和denominator为NA的问题解决了,但是retention出现了NAN,请问你出现这个问题了吗? 像下面这样: 1 NaN 1 NaN 1 NaN NaN NaN 1 NaN

jfass commented 4 years ago

@adamtongji Thank you! Your patched version https://github.com/adamtongji/kma works for me.

Interesting side note: GitHub's internal search doesn't find that repo when you search "adamtongji/kma" (all of GitHub). So I spent a while thinking it had disappeared :(

@adamtongji -- maybe submit a pull request?

adamtongji commented 4 years ago

@zhengjiantao 其实就是dplyr版本问题。。两个函数实现功能是一样的。其他的我也无法解释了。