Closed warrenmcg closed 6 years ago
Hey @pimentel, so I think I've covered my bases with the two to-dos. I don't see other clear opportunities for users to need to know whether counts or TPMs are modeled within the sleuth_live
environment. I think the print
function for sleuth_model
objects is sufficient for users to double-check which variable was modeled. Let me know what you think.
Hi @pimentel,
This is the code to extend sleuth in prep for sleuth-ALR.
Here is a summary of the changes:
Transform both counts and TPMs independently
Process TPMs & counts similarly with
process_bootstraps
andsleuth_prep
process_bootstraps
andsleuth_prep
to process TPMs similar to how counts are processed (transform TPM values; createobs_tpm
andsigma_q_sq_tpm
)extra_bootstrap_summary
isTRUE
and only processes TPMs whenread_bootstrap_tpm
isTRUE
(may speed up processing if someone is just interested in one or the other)allow TPMs to modeled by
sleuth_fit
which_var
option tosleuth_fit
to specifyobs_counts
(default) orobs_tpm
; added to theprint
function forsleuth_fit
objects to print which variable was modeled (counts or TPMs).remaining to-dos:
extendDONEsleuth_live
to allow users to look at TPM or counts if both are modeled.right now, if users want to model both TPMs and counts on the same model, they have to be stored separately; I think this should remain the case, but wanted to check on this design decision.We decided users will be forced to model each separately.