search

pachterlab / sleuth

Differential analysis of RNA-Seq
http://pachterlab.github.io/sleuth
GNU General Public License v3.0
305 stars 95 forks source link

Show %variance captured by each principal component #205

Closed ArtemSokolov closed 3 years ago

ArtemSokolov commented 6 years ago

It has become increasingly common to show % variance captured by each principal component. The proposed change computes these values on the fly and displays them directly on the axis labels.

warrenmcg commented 5 years ago

Great idea @ArtemSokolov! Thanks for doing this! I've switched this to merge your work into the develbranch, so that we can combine this with other changes before the next stable release. This should be hopefully soon!

ArtemSokolov commented 5 years ago

Thanks, @warrenmcg. I spotted a small discrepancy: my code was computing %st. d. explained, but labeling it as a %variance. The latest commit should address that.

ArtemSokolov commented 3 years ago

Dear @warrenmcg and @lakigigar,

Happy Friday. I noticed that I still have this dangling fork from over 2 years ago and wanted to check in on the status of the PR.

Please let me know if you would like to see any changes to my suggested code above. Alternatively, I am happy to close the PR if you think that the feature is not needed or conflicts with other code.

If you are happy with the proposed changes, I request that the PR is merged into pachterlab:devel, which would allow me to delete my fork.

I hope you are all doing well.

Best, -Artem

ArtemSokolov commented 3 years ago

Closing due to inactivity.