pachyderm / helmchart

Helm Chart for Pachyderm
5 stars 9 forks source link

Helm bug causing partSize to be converted to a float #71

Closed philwinder closed 3 years ago

philwinder commented 3 years ago

Hi all.

This bug took me much longer to track down that I'd like to admit!

Recreate: Use an "AMAZON" setup. E.g. https://github.com/pachyderm/helmchart/blob/master/examples/aws-values.yaml

Run that code (or just helm template if you don't want to recreate).

You'll get an error in pachd which crashes.

error setting up External Pachd GRPC Server: error setting up PFS API GRPC Server: cannot parse: strconv.ParseInt: parsing "5.24288e+06": invalid syntax

Reason: This bug: https://github.com/helm/helm/issues/1707

The partSize setting is being converted into a float by the toString method in this line: https://github.com/pachyderm/helmchart/blob/pachyderm-0.4.1-rc.1/pachyderm/templates/pachd/storage-secret.yaml#L35

Because the number is big and converted to engineering notation.

If you use a smaller number, then the toString works, but unfortunately minio requires a value of at least 5242880 to work (the default value).

I think you can work around this issue by accepting a string in your json schema, not an int. Which will be passed through to the k8s env var and interpreted as an int by pach.