search

pacific-hake / hake-assessment

:zap: :fish: Build the assessment document using latex and knitr
MIT License
13 stars 6 forks source link

Alt-text algorithm breaks those plots where layout() is used #1046

Closed cgrandin closed 1 year ago

cgrandin commented 1 year ago

Only the upper of the two plots is shown. For example the age comp fits plot (Fig 19) and the traceplots for the MCMCs in the MCMC appendix. This looks like its not too hard to fix, my task for Wed Feb 15.

There are two includegraphics[width=\maxwidth]{path/to/file} calls in a row in the input tex file in these cases. The alt-text algorithm just ignores the second on while injecting tagging structure.

Need to check for two or more. We will never use layout again once converted totally to ggplot, so maybe only worry about two for now.

cgrandin commented 1 year ago

This is a lot more work than first seems. The age fit plots cannot be placed into a cowplot grid, so they have to be rewritten so they do otherwise the alt text algorithm will fail.

I have to rewrite it in ggplot

aaronmberger-nwfsc commented 1 year ago

should these be changes earmarked for 2024 given the time it will take?

cgrandin commented 1 year ago

No I'm almost done. It has to be done to make the alt-text tagging work.