pacific-hake / hake-assessment

:zap: :fish: Build the assessment document using latex and knitr
MIT License
13 stars 6 forks source link

Groundhog Day - who's editing what? #110

Closed andrew-edwards closed 8 years ago

cgrandin commented 8 years ago

I'm automating prior values (as seen in the control file) and types in the text right now.

allan-hicks commented 8 years ago

I'll look through the one-pager and executive summary, but not until this afternoon.

On Thu, Feb 11, 2016 at 9:09 AM, cgrandin notifications@github.com wrote:

I'm automating prior values (as seen in the control file) and types in the text right now.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182961379 .

cgrandin commented 8 years ago

I will also go through as much of the doc as possible, finding any hard wired numbers, and try to generalize them if possible.

andrew-edwards commented 8 years ago

tables.reference.points.r - making row names of F_40% part in Table 13 consistent with those in Table f (and the identical Table 14)..

minnowslayer commented 8 years ago

i'm at this intermittently today but right now am identifying a couple spots where years and other quantities are hard-wired in the executive summary

On Thu, Feb 11, 2016 at 9:30 AM, andrew-edwards notifications@github.com wrote:

tables.reference.points.r - making row names of F_40% part in Table 13 consistent with those in Table f (and the identical Table 14)..

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182967875 .

minnowslayer commented 8 years ago

but all done that now

On Thu, Feb 11, 2016 at 9:58 AM, minnowslayer2002 . minnowslayer@gmail.com wrote:

i'm at this intermittently today but right now am identifying a couple spots where years and other quantities are hard-wired in the executive summary

On Thu, Feb 11, 2016 at 9:30 AM, andrew-edwards notifications@github.com wrote:

tables.reference.points.r - making row names of F_40% part in Table 13 consistent with those in Table f (and the identical Table 14)..

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182967875 .

allan-hicks commented 8 years ago

Is there a way to avoid us changing the same things? How about if we wait for Chris and Andy to go through looking for hard-wired quantities. Then we can have a closer look later to make sure it is correct?

If so, Chris and Andy, can you let us know what sections are finished and ready for further review?

On Thu, Feb 11, 2016 at 10:01 AM, minnowslayer notifications@github.com wrote:

but all done that now

On Thu, Feb 11, 2016 at 9:58 AM, minnowslayer2002 . < minnowslayer@gmail.com> wrote:

i'm at this intermittently today but right now am identifying a couple spots where years and other quantities are hard-wired in the executive summary

On Thu, Feb 11, 2016 at 9:30 AM, andrew-edwards < notifications@github.com> wrote:

tables.reference.points.r - making row names of F_40% part in Table 13 consistent with those in Table f (and the identical Table 14)..

— Reply to this email directly or view it on GitHub < https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182967875

.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182980701 .

andrew-edwards commented 8 years ago

If we agree to say here what section we are currently editing, then others can check. Yes, we want to avoid duplicating the work. We can merge frequently. I'm still doing what I said I was above (tables.reference.points.r).

minnowslayer commented 8 years ago

no problem.

On Thu, Feb 11, 2016 at 10:11 AM, Allan C Hicks notifications@github.com wrote:

Is there a way to avoid us changing the same things? How about if we wait for Chris and Andy to go through looking for hard-wired quantities. Then we can have a closer look later to make sure it is correct?

If so, Chris and Andy, can you let us know what sections are finished and ready for further review?

On Thu, Feb 11, 2016 at 10:01 AM, minnowslayer notifications@github.com wrote:

but all done that now

On Thu, Feb 11, 2016 at 9:58 AM, minnowslayer2002 . < minnowslayer@gmail.com> wrote:

i'm at this intermittently today but right now am identifying a couple spots where years and other quantities are hard-wired in the executive summary

On Thu, Feb 11, 2016 at 9:30 AM, andrew-edwards < notifications@github.com> wrote:

tables.reference.points.r - making row names of F_40% part in Table 13 consistent with those in Table f (and the identical Table 14)..

— Reply to this email directly or view it on GitHub <

https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182967875

.

— Reply to this email directly or view it on GitHub < https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182980701

.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182984155 .

allanhicks commented 8 years ago

I'm not editing anything right now, but will start after lunch.

On Thu, Feb 11, 2016 at 10:22 AM, minnowslayer notifications@github.com wrote:

no problem.

On Thu, Feb 11, 2016 at 10:11 AM, Allan C Hicks notifications@github.com wrote:

Is there a way to avoid us changing the same things? How about if we wait for Chris and Andy to go through looking for hard-wired quantities. Then we can have a closer look later to make sure it is correct?

If so, Chris and Andy, can you let us know what sections are finished and ready for further review?

On Thu, Feb 11, 2016 at 10:01 AM, minnowslayer <notifications@github.com

wrote:

but all done that now

On Thu, Feb 11, 2016 at 9:58 AM, minnowslayer2002 . < minnowslayer@gmail.com> wrote:

i'm at this intermittently today but right now am identifying a couple spots where years and other quantities are hard-wired in the executive summary

On Thu, Feb 11, 2016 at 9:30 AM, andrew-edwards < notifications@github.com> wrote:

tables.reference.points.r - making row names of F_40% part in Table 13 consistent with those in Table f (and the identical Table 14)..

— Reply to this email directly or view it on GitHub <

https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182967875

.

— Reply to this email directly or view it on GitHub <

https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182980701

.

— Reply to this email directly or view it on GitHub < https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182984155

.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-182990083 .

andrew-edwards commented 8 years ago

Done with aforementioned table edit. Will do Exec Summary - Nathan flagged some stuff which I can do now I have new models all working fine.

aaronmberger-nwfsc commented 8 years ago

I had done some updating last night on the assessment section, and noted in the assessment.rnw which ones were '2016 done'; however a good check over would be prudent either by myself or another. In most spots, I just changed it to the new value. Some of those would be difficult to automate, but some would be fairly simple.

On Thu, Feb 11, 2016 at 10:37 AM, andrew-edwards notifications@github.com wrote:

Done with aforementioned table edit. Will do Exec Summary - Nathan flagged some stuff which I can do now I have new models all working fine.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-183001313 .

Aaron M. Berger, Ph.D. Research Mathematical Statistician Fishery Resource Analysis and Monitoring Division Northwest Fisheries Science Center 2032 SE OSU Dr. Bldg. 955 Newport, OR 97365-5275

aaron.berger@noaa.gov aaron.berger@noaa.gov541.867.0562

andrew-edwards commented 8 years ago

Done with Exec Summary. Will do One-page Summary after lunch as I flagged three things earlier than I can easily verify now I have results. New issue - hungry.

allanhicks commented 8 years ago

I'll start going through the Exec Summary, if that is ok with everyone.

On Thu, Feb 11, 2016 at 12:35 PM, andrew-edwards notifications@github.com wrote:

Done with Exec Summary. Will do One-page Summary after lunch as I flagged three things earlier than I can easily verify now I have results. New issue - hungry.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-183051151 .

cgrandin commented 8 years ago

Yes, fine by me

andrew-edwards commented 8 years ago

I'm going to print and read Exec Summary, as never really did that last time. Oh, just have two minor punctuation edits for data section first.

allan-hicks commented 8 years ago

I cna commit real quick if you would like to see the changes I've made

On Thu, Feb 11, 2016 at 1:55 PM, andrew-edwards notifications@github.com wrote:

I'm going to print and read Exec Summary, as never really did that last time. Oh, just have two minor punctuation edits for data section first.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-183074580 .

andrew-edwards commented 8 years ago

Yes, I'm actually just doing the bit in Assessment section that Aaron flagged - I'd just done the same paragraph in Exec Summary.

cgrandin commented 8 years ago

I' going through sensitivity and retrospectives sections.

cgrandin commented 8 years ago

I'm heading out to pick up my kids and go home (Nadine's first day back at work after mat leave) but I will check in in an hour or so. Cheers

aaronmberger-nwfsc commented 8 years ago

I also have to head out in a bit and drive back to Corvallis... but will check in a bit later...

On Thu, Feb 11, 2016 at 3:05 PM, cgrandin notifications@github.com wrote:

I'm heading out to pick up my kids and go home (Nadine's first day back at work after mat leave) but I will check in in an hour or so. Cheers

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-183094342 .

Aaron M. Berger, Ph.D. Research Mathematical Statistician Fishery Resource Analysis and Monitoring Division Northwest Fisheries Science Center 2032 SE OSU Dr. Bldg. 955 Newport, OR 97365-5275

aaron.berger@noaa.gov aaron.berger@noaa.gov541.867.0562

allanhicks commented 8 years ago

Sounds good. We are in a good place and should have a document to distribute tomorrow before noon. Thanks everyone.

On Thu, Feb 11, 2016 at 3:06 PM, aaronmberger notifications@github.com wrote:

I also have to head out in a bit and drive back to Corvallis... but will check in a bit later...

On Thu, Feb 11, 2016 at 3:05 PM, cgrandin notifications@github.com wrote:

I'm heading out to pick up my kids and go home (Nadine's first day back at work after mat leave) but I will check in in an hour or so. Cheers

— Reply to this email directly or view it on GitHub < https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-183094342

.

Aaron M. Berger, Ph.D. Research Mathematical Statistician Fishery Resource Analysis and Monitoring Division Northwest Fisheries Science Center 2032 SE OSU Dr. Bldg. 955 Newport, OR 97365-5275

aaron.berger@noaa.gov aaron.berger@noaa.gov541.867.0562

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-183094607 .

andrew-edwards commented 8 years ago

Sounds good. I'm off soon and will get the Exec Summary read through (something I ran out of time to do on Monday, so that'll be good). Thought I was up-to-date, but just seen a bunch more commits. I'll merge tomorrow. 160-page document updated in essentially a day (after you guys spent a couple of days doing model runs). Nice.

aaronmberger-nwfsc commented 8 years ago

Agreed. All that hard work with set-up I thought would really pay off next year, but seeing major benefits already!

On Thu, Feb 11, 2016 at 3:44 PM, andrew-edwards notifications@github.com wrote:

Sounds good. I'm off soon and will get the Exec Summary read through (something I ran out of time to do on Monday, so that'll be good). Thought I was up-to-date, but just seen a bunch more commits. I'll merge tomorrow. 160-page document updated in essentially a day (after you guys spent a couple of days doing model runs). Nice.

— Reply to this email directly or view it on GitHub https://github.com/cgrandin/hake-assessment/issues/110#issuecomment-183111930 .

Aaron M. Berger, Ph.D. Research Mathematical Statistician Fishery Resource Analysis and Monitoring Division Northwest Fisheries Science Center 2032 SE OSU Dr. Bldg. 955 Newport, OR 97365-5275

aaron.berger@noaa.gov aaron.berger@noaa.gov541.867.0562

cgrandin commented 8 years ago

Looks like everything is ok! I'll get to work in the morning to do a final check. Cheers guys!