base_model$mcmcvals$dm_weight_survey_median is incorrect

pacific-hake / hake-assessment

:zap: :fish: Build the assessment document using latex and knitr

MIT License

13 stars 6 forks source link

base_model$mcmcvals$dm_weight_survey_median is incorrect #1117

Closed aaronmberger-nwfsc closed 10 months ago

aaronmberger-nwfsc commented 10 months ago

The value loaded into mcmcvals for the dm_weight_survey_median is incorrect. It currently is loaded with the value for dm_weight_fishery_median. These are used in the sensitivity section to auto-populated the correct values. I've updated the text to be correct once the this is fixed.

I tracked the issue back to load-mcmc-vals.R, but have stopped there.

cgrandin commented 10 months ago

Does this make more sense

cgrandin commented 10 months ago

It's fixed. You need to re-download the base model. Once loaded you can check this by looking at

base_model$mcmcvals$dm_weight_survey_median

Kelli fixed the bug awhile ago but the routine to build the RDS file hadn't been run again since so it remained the same as the value in base_model$mcmcvals$dm_weight_fishery_median

aaronmberger-nwfsc commented 10 months ago

Yes, those numbers match my hand calculations, so all good.