pacific-hake / hake-assessment

:zap: :fish: Build the assessment document using latex and knitr
MIT License
13 stars 6 forks source link

Table 15 M prior values of mean and SD look wrong #791

Closed andrew-edwards closed 3 years ago

andrew-edwards commented 3 years ago

They are: image

Last year were 0.20 and 1.11.

andrew-edwards commented 3 years ago

Text in 2.4.1 is correct (though values are hardwired).

cgrandin commented 3 years ago

These are correct this year, and were wrong last year. -1.61 and 0.10 are the logs of 0.2 and 1.11 and the values should be in the log domain

andrew-edwards commented 3 years ago

Also the age ranges in the selectivity parameters are wrong I think (different to last year's). This year:

image

2020 assessment:

image

The "ages: XX-XX" have all changed.

Also survey no. of parameters and higher bound have changed.

[I can look into later, just want to keep reading for now so mentioning such things]

andrew-edwards commented 3 years ago

Text in 2020 (and now) both say age-specific selectivity begins at age-2 for survey and age-1 for fishery, which is inconsistent with last year's table. (Now I'm confused!).

kellijohnson-NOAA commented 3 years ago

It is using grep and hardwired line numbers to get this, so it is just a minor thing in the code that makes the table. Thanks for catching it. I will fix.

On Sun, Feb 7, 2021 at 11:35 AM Andrew Edwards notifications@github.com wrote:

Text in 2020 (and now) both say age-specific selectivity begins at age-2 for survey and age-1 for fishery, which is inconsistent with last year's table. (Now I'm confused!).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pacific-hake/hake-assessment/issues/791#issuecomment-774743792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7LCFBPPEDTAA2B5NRKCZDS53TPJANCNFSM4XHWFEKQ .

-- Kelli Faye Johnson, PhD Research Fish Biologist Northwest Fisheries Science Center National Marine Fisheries Service 2725 Montlake Boulevard East Seattle, Washington 98112 (206) 860-3490 kelli.johnson@noaa.gov

aaronmberger-nwfsc commented 3 years ago

Yes, this can be a tricky one to explain because fishery selectivity is age-1 to 6+ and survey is age-2 to 6+ where the plus is a single "group" parameter, but there are only 5 parameters per year for fishery and 4 for survey (i.e., Num ages -1 due to the "relativeness" of selectively where one parameter is unity and others are estimated relative to it).

On Sun, Feb 7, 2021 at 11:53 AM Kelli Johnson notifications@github.com wrote:

It is using grep and hardwired line numbers to get this, so it is just a minor thing in the code that makes the table. Thanks for catching it. I will fix.

On Sun, Feb 7, 2021 at 11:35 AM Andrew Edwards notifications@github.com wrote:

Text in 2020 (and now) both say age-specific selectivity begins at age-2 for survey and age-1 for fishery, which is inconsistent with last year's table. (Now I'm confused!).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/pacific-hake/hake-assessment/issues/791#issuecomment-774743792 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA7LCFBPPEDTAA2B5NRKCZDS53TPJANCNFSM4XHWFEKQ

.

-- Kelli Faye Johnson, PhD Research Fish Biologist Northwest Fisheries Science Center National Marine Fisheries Service 2725 Montlake Boulevard East Seattle, Washington 98112 (206) 860-3490 kelli.johnson@noaa.gov

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pacific-hake/hake-assessment/issues/791#issuecomment-774747809, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4T76TAZMZ4B4SKU477YTLS53VU7ANCNFSM4XHWFEKQ .

-- Aaron Berger, PhD https://www.fisheries.noaa.gov/contact/aaron-m-berger-phd Fisheries Resource and Monitoring Division Northwest Fisheries Science Center National Marine Fisheries Service National Oceanic and Atmospheric Administration 2032 SE OSU Drive Newport, OR 97365 USA

aaron.berger@noaa.gov aaron.berger@noaa.gov541.867.0562 (office)

541.231.1417 (cell)

kellijohnson-NOAA commented 3 years ago

is the text for the M section on the scales and with the right wording? If, so I will code it from m.prior. Just wondering if people want something different to be reported here?

cgrandin commented 3 years ago

I’ll look at that part of nobody has

kellijohnson-NOAA commented 3 years ago

Thanks Chris.

cgrandin commented 3 years ago

I was right there looking through it so I just made the change. It should be the same as in the table and in lognormal space.