search

pacific-hake / pacifichakemse

A Management Strategy Evaluation for Pacific Hake
3 stars 2 forks source link

Inconsistency in CSV File Years for MSE: Seeking Clarification for the Year 2018 (pacifichakemse/inst/extdata/csv-data) #14

Open sacurin opened 6 months ago

sacurin commented 6 months ago

Does anyone know why the CSV files used in MSE don't have the same length of years? For example, for the year 2018 (pacifichakemse/inst/extdata/csv-data)

  1. can-ft-catch-by-month (data until 2019)
  2. can-ss-catch-by-month (data until 2019)
  3. catch_per_country (data until 2018)
  4. catches (data until 2017)
  5. landings-tac-history (data until 2019)
  6. us-cp-catch-by-month (data until 2019)
  7. us-ms-catch-by-month (data until 2019)
  8. us-research-catch-by-month (data until 2018)
  9. us-shore-catch-by-month (data until 2019)
aaronmberger-nwfsc commented 6 months ago

My guess is that the incomplete ones are simple aggregations of the other complete ones (e.g., catch_per_country is the sum across months for each fleet in a country). And somewhere during development, those aggregation files were perhaps not used and thus not updated (i.e., catch by month and fleet was just used as the 'raw' data).

kristinmarshall-NOAA commented 6 months ago

Aaron's guess makes sense to me. It seems like the 2019 observations wouldn't actually be used in the code. But that is something we can track down in the load and run functions.