pacific-hake / pacifichakemse

A Management Strategy Evaluation for Pacific Hake
3 stars 2 forks source link

Add attainment rate functionality #3

Open kristinmarshall-NOAA opened 3 years ago

kristinmarshall-NOAA commented 3 years ago

We need to add an attainment rate to run the attainment scenarios for the JMC. This will probably involve:

-add the parameter to the om data frame such that it can be modified in the run scripts

cgrandin commented 3 years ago

I did this in 4e2b5204e945993e8f0b6f973396230279e094a1, and https://github.com/pacific-hake/runhakemse/commit/cdc66c7a422e85ba1dca6e141e17e2a86da07c9c and ran them overnight for 20 runs. I will post back once I fixed some of the palette color issues (over 8 scenarios requires new palette) for the plots.

iantaylor-NOAA commented 3 years ago

Nice work @cgrandin! Out of the 9 cases, I think interpretation might be easier if the results were split into 2 groups as follows, where the contrast among scenarios in the first group will be presumably much larger than the second, so this would allow better examination of the differences in the second group:

c("01_us_0_can_0",
  "02_us_100_can_100",
  "03_us_0_can_100",
  "04_us_100_can_0")

c("05_us_77_can_56",
  "06_us_90_can_56",
  "07_us_60_can_56",
  "08_us_77_can_70",
  "09_us_77_can_90")
cgrandin commented 3 years ago

That’s a good idea, The plot with all nine is very busy. Do you think the unfished baseline one should appear on both though?

iantaylor-NOAA commented 3 years ago

I would defer to Kristin's judgement on that, but if 6 per figure isn't too many, adding unfished to all seems like a good idea.

On Fri, Nov 20, 2020 at 10:30 AM Chris Grandin notifications@github.com wrote:

That’s a good idea, The plot with all nine is very busy. Do you think the unfished baseline one should appear on both though?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pacific-hake/pacifichakemse/issues/3#issuecomment-731338370, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGC7FWJ3UUIEMUNDP7YESTSQ2YV3ANCNFSM4T5AA2WQ .