search

pacificIT / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 1 forks source link

Param target_domain in CefAddCrossOriginWhitelistEntry() should be optional #609

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. CefAddCrossOriginWhitelistEntry("customstd://test1", "http", "", true)
2.
3.

What is the expected output? What do you see instead?
Calling CefAddCrossOriginWhitelistEntry("customstd://test1", "http", "", true) 
can make customstd://test1 access all http origin, but the function returned 
because param target_domain is null.

What version of the product are you using? On what operating system?
cef r603.

Please provide any additional information below.

Function OriginAccessEntry::matchesOrigin(const SecurityOrigin& origin) will 
return true when "if (m_subdomainSettings == AllowSubdomains && 
m_host.isEmpty())", so pass empty param target_domain in 
CefAddCrossOriginWhitelistEntry() will work.

CefRemoveCrossOriginWhitelistEntry() should make param target_domain optional, 
too.

Original issue reported on code.google.com by Zhaojun....@gmail.com on 28 May 2012 at 1:32

GoogleCodeExporter commented 9 years ago 
Fixed in CEF1 trunk revision 667 and CEF3 trunk revision 668.

Original comment by magreenb...@gmail.com on 4 Jun 2012 at 6:45