Mapping tables key fixes

pacifica / pacifica-metadata

Pacifica core service that stores the metadata for the system

GNU Lesser General Public License v3.0

1 stars 8 forks source link

Mapping tables key fixes #237

Closed kauberry closed 5 years ago

kauberry commented 5 years ago

Description

Changing the way that mapping tables have their values hashed. This looks at the foreign-key relationships in the table, but removes the "relationship" and "uuid" columns, as they aren't part of the EUS schema that we're comparing against.

Issues Resolved

Fixes #236

Check List

[x] All tests pass. See https://github.com/pacifica/pacifica-docs/blob/master/development/TESTING.md
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable

dmlb2000 commented 5 years ago

@kauberry I'm not sure changing get_primary_keys() to not return the primary keys for the object is the right answer.

Thought, if a user hits the objectinfo endpoint to get a hashlist the optional where_args are not used in that case. Could you use the where_args to pass into the available_hash_list() method a list of columns to hash, instead of just assuming the columns are the primary keys?

dmlb2000 commented 5 years ago

@kauberry I'm going to close this in favor of #242.

That option allows users to pass get args to the hashlist method to hash on specific columns.

/objectinfo/users/hashlist?first_name=0&last_name=0

The values don't matter so much as the keys are used to generate the hashes.