search

pacificclimate / climate-explorer-data-prep

0 stars 0 forks source link

Convert prsn data from mm to cm #113

Open eyvorchuk opened 4 years ago

eyvorchuk commented 4 years ago

The generate_climos.py and generate_prsn.py files have been modified to convert the prsn data from mm to cm (equivalently, kg/m2 to g/cm2). The test_generate_prsn.py file has an additional assert statement to ensure the correct units.

rod-glover commented 4 years ago

I have a question: Why convert units? P2A, at least, converts units on the frontend; that is a presentation issue, which is the responsibility of the UI, not of the data backend. Possibly the Marmot may need this, possibly lacking units conversions? (That can be remedied, particularly given the utilities now in P2A.)

eyvorchuk commented 4 years ago

I have a question: Why convert units? P2A, at least, converts units on the frontend; that is a presentation issue, which is the responsibility of the UI, not of the data backend. Possibly the Marmot may need this, possibly lacking units conversions? (That can be remedied, particularly given the utilities now in P2A.)

I'm not sure. @corviday wrote the original issue.

corviday commented 4 years ago

I forgot I'd written that issue. At the time I wrote it, we did not yet have p2a, just PCEX, so it didn't occur to me that we might do unit conversion in the front end instead.