pacificclimate / climate-explorer-frontend

6 stars 1 forks source link

Implement UI changes/fixes requested by RCI #465

Closed eyvorchuk closed 3 months ago

eyvorchuk commented 4 months ago

This PR contains the UI changes/fixes RCI requested while experimenting with the MBCn climatologies page. These are the changes:

Demo available at https://services.pacificclimate.org/dev/pcex/app/#/data/climo/ce_files

eyvorchuk commented 3 months ago

@rod-glover

Can you provide an example case where this dropdown appears? I don't see it in any of the cases I pulled up.

Could we meet to see what you're looking at? I just opened the demo and I was able to see the dropdown in the Change From Baseline graph.

I don't see any difference in the label or the content for Filtered Datasets Summary. run_id is included/excluded with MIROC5/PCIC12 respectively in Data Map, but not in Filtered Datasets Summary.

Sorry, I should've worded this better for the Filtered Datasets Summary. Only the Label in Selectors column excludes the run_id in cases where a model has only one run. Currently in production, for PCIC12 from 1971-2000 as an example, that column displays the label as rXi1p1 1971-2000, but with this change, the label will be 1971-2000 instead.

rod-glover commented 3 months ago

@rod-glover

Can you provide an example case where this dropdown appears? I don't see it in any of the cases I pulled up.

Could we meet to see what you're looking at? I just opened the demo and I was able to see the dropdown in the Change From Baseline graph.

I see now that the "Dataset" dropdown is what we're talking about. I misinterpreted it and thought it chose which future dataset (or something) would be displayed. For an inexpert (or inattentive) user, I think a better label here would be "Baseline".

I don't see any difference in the label or the content for Filtered Datasets Summary. run_id is included/excluded with MIROC5/PCIC12 respectively in Data Map, but not in Filtered Datasets Summary.

Sorry, I should've worded this better for the Filtered Datasets Summary. Only the Label in Selectors column excludes the run_id in cases where a model has only one run. Currently in production, for PCIC12 from 1971-2000 as an example, that column displays the label as rXi1p1 1971-2000, but with this change, the label will be 1971-2000 instead.

Ah, understood now.