search

pacificclimate / climdex.pcic

Routines to compute ETCCDI Climdex indices
GNU General Public License v3.0
22 stars 13 forks source link

Register C functs using R_registerRoutines; fixes #16 #17

Closed corviday closed 6 years ago

corviday commented 6 years ago

Fixes a best practices note generated while building the climdex.pcic package.

Here's the new build output.

Here's the old build output, with the note in it.

jameshiebert commented 6 years ago

The code here looks good. Thanks for figuring out the best practices and implementing them. One thing to note... in the past our usual MO for resubmitting packages after feedback is to increment the version and sumbit a new version. If CRAN had a way to submit release candidates, this would be better, but they don't. Could you push a commit to this branch that increments the version and prepends to the CHANGELOG? Then tag/build/upload. Sounds like more work, but we have found that it's far more clear to never, ever re-use a version number once it has been "minted".

jameshiebert commented 6 years ago

Looks great!