Closed QSparks closed 1 month ago
The GH action to test on PR is failing for macOS-latest. This isn't related to code changes in the PR, confirmed by running the action on another previously passing PR.
Reason? All the x86 architectures were intentionally skipping the two failing tests. We aren't testing any ARM architecture.
Solution:
Use an Intel runner for now and open a separate issue to support Apple Silicon.
Drop macOS testing and open a separate issue
Related:
https://github.com/actions/runner-images/issues/9741
Summary
This PR refactors the original
climdex.R
file by breaking it into multiple smaller, focused R scripts. There are no changes to the functionality; this is purely an organizational refactor. R CMD check runs without errors, warnings, or notes and all tests pass.Changes Made
Refactoring into Modular Scripts:
climdexInput_class.R
: Contains the definition of theclimdexInput
class and its associated methods, and validation routines.precipitation_indices.R
temperature_indices.R
threshold_indices.R
date_utils.R
series_utils.R
stats_utils.R
threshold_utils.R
Documentation Updates
Encoding: UTF-8
to handle✖ roxygen2 requires "Encoding: UTF-8"
errorstats
andutils
to imports to handle errors such as:no visible global function definition for ‘read.csv’
Roxygen: list(markdown = TRUE)
and updatedRoxygenNote
to version7.3.2
.climdex.pcic-package.R:
.registration = TRUE
to the@useDynLib
tag so that roxygen2 would add it the namespace.@docType "package"
to_PACKAGE
.roxygen2::roxygenize(clean=T)
resolves: #35