watershed outlet-finding script has extra boolean

pacificclimate / data-prep-actions

Data Preparation actions - record of ephemera used to prepare data for PCIC data portals and other tools

0 stars 0 forks source link

watershed outlet-finding script has extra boolean #63

Open corviday opened 1 year ago

corviday commented 1 year ago

When you run the watershed outlet-finding script, you get this error:

Traceback (most recent call last):
  File "mouths-of-watersheds.py", line 67, in <module>
    if not cell_routing.mask and not flag:
NameError: name 'flag' is not defined

Removing and flag seems to fix it.

rod-glover commented 1 year ago

That does leave the question hanging there: "What is/was flag supposed to be?"

corviday commented 1 year ago

This script also labels a column WTRSHDGRPC (alphanumberic index) but outputs WTRSHDGRPD (numerical index) into that column. A minor quibble; either one uniquely identifies a watershed, but slightly confusing.

corviday commented 1 year ago

Other changes that would be nice for increased flexibility, as this script is applied to more data going forward:

[ ] Accept a shapefile as input, instead of a geoserver response; geoserver will probably not be part of this toolchain much longer
[ ] Accept an argument indicating which attribute to output as the identifying attribute in the output CSV. Currently it is hardcoded to output WTRSHDGRPD, not all shapefiles have one of those.