search

pacificclimate / pdp

The PCIC Data Portal - Server software to run the entire web application
GNU General Public License v3.0
1 stars 2 forks source link

Jenkins Pipeline Update #149

Closed nikola-rados closed 4 years ago

nikola-rados commented 4 years ago

This update applies the new features found in the climate-explorer-frontend Jenkinsfile.

Features added:

These features are found in two other projects and will eventually be factored out.

nikola-rados commented 4 years ago

The functionality added was to collect and process the git tags. These changes do not just apply to master. If the branch is master and is tagged on git, we want to push the git tag(s) along with the latest tag to docker hub. If the branch is not master we use the branch name as the tag.

nikola-rados commented 4 years ago

Rather than open another PR for another Jenkinsfile update, I thought I would extend this one. The changes in the most recent commit maintain the same functionality added by this PR, but do so using the shared library.

corviday commented 4 years ago

After the most recent commit, the new version seems to be behaving differently than the old version. Is that intentional? Before 42d0286, a new image appeared on docker-dev01 as pcic/pdp with a tag matching the branch name. Now images are showing up as pdp/branch-name with a tag of latest.

Here's an image from last month and an image from today:

[lzeman@docker-dev01 ~]$ docker images | grep test-jenkins
pdp/test-jenkins-2                                                                    latest                    5ff59a3c55cd        2 minutes ago       1.2GB # new version
pcic/pdp                                                                              test-jenkins              b2a9c4ffcb05        4 weeks ago         1.2GB # old version
nikola-rados commented 4 years ago

@corviday that was not intended. Did you produce that image?

nikola-rados commented 4 years ago

I re-ran the pipeline (with a small change that wasn't relevant to image naming) and it produced the expected output. Would you be able to tell me how you produced the result you got?

corviday commented 4 years ago

Hm, I might have branched off the wrong place for my tests. I'll try again.