search

pacificclimate / pdp_util

A package supplying numerous apps for running PCIC's data server
GNU General Public License v3.0
0 stars 0 forks source link

Upgrade pydap.handlers.pcic requirement #4

Closed jameshiebert closed 7 years ago

jameshiebert commented 8 years ago

pydap.handlers.pcic is pegged at v0.0.4 in the requirements.txt, but we've tagged several versions since then.

Upgrade the requirement (to at least 0.0.7) and ensure that all of the tests pass.

CBMasri commented 7 years ago

Okay, I had a look and the reason the xls_response test fails using the latest pydap.handlers.pcic package (0.0.7) is because of the addition of a new global attribute "elevation". The assertions in the test case are performed against these global values using a numerical index, so adding the extra attribute threw everything off by one.

jameshiebert commented 7 years ago

OK, good to know. Thanks for the detective work. Just to clarify, does that mean that all of the pdp_util tests will pass using pydap.handlers.pcic v0.7.0? If so, then I guess we just want to bump the requirement version (and release a new version of pdp_util) in this package, and then update the tests and the requirements.txt in pdp.

CBMasri commented 7 years ago

All except one passes: test_auth redirect returns 401 Unauthorized. It looks like there have been some changes to OpenID since the test case was written, perhaps the link has changed?

jameshiebert commented 7 years ago

Hrm yeah. OpenID has been dead for a while. Feel free to mark that test as skipped.