pacificclimate / pdp_util

A package supplying numerous apps for running PCIC's data server
GNU General Public License v3.0
0 stars 0 forks source link

Fix method to discriminate climatological variables #55

Closed rod-glover closed 8 months ago

rod-glover commented 8 months ago

Resolves #50

Notes for reviewers:

corviday commented 8 months ago

The test data loaded from PyCDS has changed. There are fewer observations (I think); this accounts for some stations with null values for min/max obs time, variable tags, etc. Variable definitions have also been changed.

I saw something like this updating tests for the station data portal backend. Previously the test dataset had explicitly inserted some rows into the VarsPerHistory when it was a managed matview; when it was converted into a native matview the test harness couldn't insert rows, and none were generated "naturally", as that variable didn't actuallly have any associated observations.