pacificclimate / scip-frontend

Salmon Climate Impacts Portal
GNU General Public License v3.0
1 stars 1 forks source link

Show indicator data on the map #58

Closed corviday closed 7 months ago

corviday commented 9 months ago

Adds the functionality to view indicator data on the map. To see indicator data, you can pick any of the indicators on the Yearly, Monthly, or Daily tabs. The arrows below the map allow you to go forward and backwards one timestep or jump to the next or previous climatology.

Very interested in feedback on the map colours. It was difficult to find balance between colours palettes that sort of evoked the thing being measured, were visible against the background, and were sufficiently differentiated between high and low values.

Demo

This is the last bit of functionality to be added before initial release, so I am also very interested in any places the UI feels clunky, buggy, confusing, or ugly.

resolves #37 resolves #47

corviday commented 9 months ago

That is extremely unexpected behaviour (which I have confirmed). I think I may have somehow deployed the wrong version.

corviday commented 9 months ago

Thank you for your detailed response!

Do the palettes have to evoke the thing being measured? Or can we free ourselves of that given that they aren't displayed simultaneously? Would that make things simpler?

My reasoning behind the palette evoking the thing being measured is that the viewer can tell intuitively which colour is a high value and which colour is a low value. Specifically: I have made high water temperatures red and low water temperatures blue. I have made high streamflow rates dark blue and low flow rates light blue (streamflow is the one that is kind of hard to read on the map, I feel). The other measures, like "which day if the year has the highest flow" I just put a spectrum on, chosen only for its visibility and readability. I certainly could use the plain spectrum for everything, it is very easy to read, but I worry that having either cool colours for high temperature or warm colours for high flow would be more confusing that it is worth.

An intermediate path might be to use the nice spectrum for everything, but switch which end is high and which end is low to match our intuitions about what colour temperatures should be, though I'm not sure if that's any less confusing.

Can the the basin/ watershed area not be filled with the flow network?

It was not intended to be, but I accidentally deployed an ugly merge artifact instead of the real demo.

corviday commented 8 months ago

Changes suggested in comments above or in emails and discussions elsewhere to add to this PR:

corviday commented 8 months ago

Suggested at demo this morning: