pacificclimate / scip-frontend

Salmon Climate Impacts Portal
GNU General Public License v3.0
1 stars 1 forks source link

Small UI Improvements based on scientist feedback #64

Closed corviday closed 6 months ago

corviday commented 6 months ago

This PR combines a few small UI improvements requested by scientists:

  1. Different spatial organization of river basins (split mainland into multiple basins) (basins.yaml - most of the work here was in the database)
  2. Add a note that you can only view salmon populations if we also have indicator data for them (PopulationTable.js)
  3. Allow users to choose whether to view indicator data averaged over the entire region, or only at the outlet point (AreaDisplay.js, OutletToggle.js, DailyDataDisplay.js, MonthlyDataDisplay.js, YearlyDataDisplay.js, useStore.js)
  4. Enable logarithmic colour scaling for certain indicators only (MapControls.js, LogscaleCheckbox.js)
  5. Disable logarithmic colour scaling entirely, because upon further examination, all the data files for those indicators contain zero values and cannot be viewed with logarithmic colour scaling after all - ncWMS throws an error if you ask it to generate a logarithmic image of a dataset with zeroes in it (MapControls.js, LogscaleCheckbox.js)

Since these are UI changes, please feel free to weigh in on where the UI is clunky or could be improved.

Demo

Resolves #60

rod-glover commented 6 months ago

UI feedback:

Controls immediately below the map:

Behaviour issues:

Missing data?

  1. Select basin Haida Gwaii and an indicator
  2. The map shows a raster overlaying other parts of the province but not Haida Gwaii.
  3. Q: Is that intended? To the naive eye (which may not be the target user group), it is confusing. The graphs all show zero -- so perhaps this is a result of missing data?

No indication when watershed selection is required.

  1. Select basin Fraser River
  2. Select a Yearly indicator.
  3. Indefinitely persisting message "Loading data..." in graph area. Looks as if there is something wrong.
  4. Select watershed.
  5. Yearly indicator data actually loads and shows.
  6. This is confusing: No indication that you have to select a watershed. And in some cases (e.g., Haida Gwaii) you can't select a watershed. Need better feedback from the UI here ... probably a different message in the graph area. This could be a great place to provide instructions on what to do to cause a graph to appear.
  7. Also confusingly: If you select a CU first and view an indicator, then switch to a basin but no watershed, the previous graph persists until you select a watershed. The graph state is not being reset.
corviday commented 6 months ago

Missing data?

Haida Gwaii was erroneously included on the whitelist of selectable river basins. Thank you for catching that.

corviday commented 6 months ago

Thank you for the detailed feedback.

Changes: