Add colour scale to Anomaly map

pacificclimate / weather-anomaly-tool

0 stars 0 forks source link

Add colour scale to Anomaly map #84

Closed rod-glover closed 10 months ago

rod-glover commented 10 months ago

Resolves #78 Resolves #89

rod-glover commented 10 months ago

Demo

@jameshiebert , a few things to note in this PR:

Added colour scale to anomaly map, as requested in issue
Added a clarifying annotation in other maps (they use single-colour markers)
Added a "much greater than anything sane" range to the precip anomaly colour scale, coloured red. This clarifies what is going on (somewhat), but it also calls out our problem unmistakeably. Thoughts? Easy enough to revert or modify.
This PR follows one changes to the BC Albers Lite basemap. This is much better than the currently deployed production version (!). I don't know why that version was not deployed sooner. But have a look.

rod-glover commented 10 months ago

Demo redeployed

rod-glover commented 10 months ago

Thanks, James.

I did get rid of the basemap fader. I thought that the BC Albers Lite tiles were sufficiently muted, but evidently that is not the case for you, and I see your point.
- I can restore the fader. I'll do that in a separate PR.
- Alternatively, I can try using full-opacity markers. I'll try that first and if I like it I'll redeploy with that.
Done. Note altered colour, shape and annotation for the final interval; this is all driven by a config (when the config is externalized, even better). I changed the colour a little bit, but I don't think it improved things. I will continue to experiment.

Demo redeployed

rod-glover commented 10 months ago

Demo redeployed

@jameshiebert

I modified the markers, and I think they don't fade into the background the way they did before. They have a grey border to highlight the marker's existence. They look oddly pastel now, despite the colours not being changed, and the opacity being increased slightly to counteract that. But if that works for you, it works for me and it is simpler than adding a map fader.
Using a pale magenta, which is both distinct and less eye-catching (to my eye, at least). Thanks, @corviday , for the suggestion.

rod-glover commented 10 months ago

I've addressed the feedback here and I think it is good enough for now. A PR coming soon will put these configurations into an external file so that future modifications are at deploy time.