search

package-url / packageurl-js

JavaScript implementation of the package url spec
MIT License
26 stars 21 forks source link

Incorrect parsing of PURLs begining with `pkg://` #58

Closed matt-phylum closed 3 weeks ago

matt-phylum commented 10 months ago

The PURL test suite contains the PURL pkg://maven/org.apache.commons/io which is supposed to parse as a namespace of org.apache.commons and a name of io, but packageurl-js parses it as having no namespace. The namespace just disappears. It doesn't become part of the name.

aniruth37 commented 9 months ago

Raised https://github.com/package-url/packageurl-js/pull/62 to fix this

jdalton commented 3 months ago

Cannot reproduce bug given the example above: https://github.com/package-url/packageurl-js/pull/62#issuecomment-2115067509

matt-phylum commented 3 months ago

This is still reproducible with the given example.

jdalton commented 3 months ago

Ah, my bad. @matt-phylum you are correct.

jdalton commented 3 weeks ago

Fixed in master branch.