Fix issues #58 & #63 - Githubissues

package-url / packageurl-js

JavaScript implementation of the package url spec

https://www.npmjs.com/package/packageurl-js

MIT License

26 stars 21 forks source link

Fix issues #58 & #63 #62

Closed aniruth37 closed 3 months ago

aniruth37 commented 11 months ago

Fix issue https://github.com/package-url/packageurl-js/issues/58 - Incorrect parsing of PURLs beginning with pkg://
Fix issue https://github.com/package-url/packageurl-js/issues/63 - Incorrect parsing of PURL with leading '/' in namespace

Fix Description

strip /, // and /// as possible in pkg:/ or pkg:// or pkg:/// before passing into URL constructor
filter for non-empty items in namespaceComponents

aniruth37 commented 11 months ago

@steven-esser Please review this

aniruth37 commented 9 months ago

@matt-phylum please review this

aniruth37 commented 8 months ago

@pombredanne, @steven-esser Can you please review this PR

jdalton commented 6 months ago

I cannot reproduce #58 on master branch.

PackageURL.fromString('pkg://maven/org.apache.commons/io')

outputs

{
  "type": "maven",
  "name": "io",
  "namespace": "org.apache.commons",
  "version": null,
  "qualifiers": null,
  "subpath": null
}

matt-phylum commented 6 months ago

Are you sure? That is not the behavior I get on the master branch (commit aa6d185251e3ec4e6fbc80489374c5fede9ccca1).

> PackageURL.fromString('pkg://maven/org.apache.commons/io')
PackageURL {
  type: 'maven',
  name: 'io',
  namespace: null,
  version: null,
  qualifiers: null,
  subpath: null
}

jdalton commented 6 months ago

Ah, my bad!

jdalton commented 3 months ago

Closing as covered by https://github.com/package-url/packageurl-js/pull/71