search

package-url / packageurl-js

JavaScript implementation of the package url spec
https://www.npmjs.com/package/packageurl-js
MIT License
26 stars 21 forks source link

feat: narrow types and optimize #68

Closed jdalton closed 6 months ago

jdalton commented 6 months ago

This PR narrows the result types from string | undefined | null to string | undefined while still accepting nulls. It also optimizes things a bit.

jdalton commented 6 months ago

BTW in the meantime I'm maintaining a fork @jdalton/packageurl-js at https://github.com/jdalton/packageurl-js/tree/jdalton/fork that has all open issues resolved.

steven-esser commented 6 months ago

@jdalton Thanks for the PR. Sorry about the lack of response in this repo, I have been busy with work and family life. I should be a bit more active now and will handle updating the repo with the various fixes in flight.

jdalton commented 6 months ago

@steven-esser

Sorry about the lack of response in this repo, I have been busy with work and family life. I should be a bit more active now and will handle updating the repo with the various fixes in flight.

No worries. I totally get it (I'm in a similar boat). I'm trickling in PRs for ya.