search

packagecontrol / channel

Package Control Libraries Channel
https://packagecontrol.github.io/channel/
3 stars 5 forks source link

Provide "python-docx" from pypi #4

Closed writeml closed 8 months ago

writeml commented 8 months ago

This commit replaces legacy dependency repo for python-docx by pypi releases.

It drops support for python 3.3, as no *.whl file exists for v0.8.11, which is the most recent version that supports 3.3.

Can/Will add back the legacy dependency repo for python 3.3 in a follow-up commit, if needed (will discuss in PR).

See: https://github.com/packagecontrol/channel/issues/1

writeml commented 8 months ago

As you can see from my commit and commit notes, this drops support for Python 3.3, as there is no wheel file available for version 0.8.11 of the project (the most recent version that still supported 3.3)...

If we feel it's necessary to support 3.3, I can easily update this branch to point 3.3 to my existing dependency repo, and I'll update my repo to v.0.8.11 as well (it's on v0.8.10 currently)... However, I strongly believe I am likely the only person currently using this library, and my package (to be released soon-ish) is already set to target 3.8, so it's really up to y'all if we want to do all we can to make libraries support all versions of Python currently supported by Sublime Text itself... I really don't mind one way or the other...

deathaxe commented 8 months ago

We shouldn't drop python 3.3 dependencies as it is unclear, who uses them.

If no wheel exists, we should keep shipping existing dependencies for 3.3 and add another release branch for 3.8

If neccessary, we can also collect all those legacy dependencies in this organization to archive them.

writeml commented 8 months ago

Understood 👍 Python 3.3 version restored in latest commit.