search

packagecontrol / st_package_reviewer

A tool to review packages for Sublime Text
MIT License
15 stars 3 forks source link

Check for img in README if it's a theme or color scheme #2

Open math2001 opened 7 years ago

math2001 commented 7 years ago

Hi!

I've been looking at the code, and I saw that you were checking if there is readme. So maybe you could also check for an image if there is a .sublime-theme or .tmTheme in the package.

Thanks for package_reviewer anyway 👍

Matt

FichteFoll commented 7 years ago

This is going to be difficult, because at this moment the checks are self-contained and I do readme checking in the repository tests (because github can detect mutiple readme locations) but would have to look for theme or color schemes file in the actual package (which I download later).

I'll have to think about how I would go about this, but thanks for the useful suggestions.

Kristinita commented 7 years ago

@math2001 , GitHub file README.MD provide limited features (for example, users don't can use JavaScript). I move description of my theme/scheme to HTML-file.

I don't think, that image in README.MD must be necessarily.

Thanks.