Header - Githubissues

packagex-io / bubbles-react-native

A React Native UI Kit

MIT License

1 stars 1 forks source link

Header #3

Open vpanyushenko opened 2 years ago

vpanyushenko commented 2 years ago

Every page has a header with the page title, breadcrumbs. The Header can also have Buttons that can be clicked on for global page settings.

https://bubbles-pied.vercel.app/header

vpanyushenko commented 1 year ago

Some issues with the header:

[ ] We need to make the font size smaller. It currently only fits only 4-5 characters
[ ] If there are no breadcrumbs, there should not be a back button
[ ] The button(s) on the right should take an array of Button components.
[ ] hrefs on the breadcrumbs do not seem like we can interact with them

clearly-outsane commented 1 year ago

Thanks for listing all of these for all the components! I didn't have a lot of finer direction till now and these help a lot.

Question - how would you like hrefs to behave on mobile? Do they navigate to a page within the app or do they open the link in a mobile browser? I could of course support both but haven't done it yet

vpanyushenko commented 1 year ago

I actually don't think we need breadcrumbs on mobile. None of out designs actually use them and mobile designs should never be that nested anyway. We can remove breadcrumbs.

clearly-outsane commented 1 year ago

I guess the PKX design system on Figma isn't fully up to date then? In that case I'll ask questions here for things I need clarity on