packbackbooks / lti-1-3-php-library

A library used for building IMS-certified LTI 1.3 tool providers in PHP.
Apache License 2.0
39 stars 25 forks source link

Prepare the library for being hosted on packagist #1

Closed dbhynds closed 3 years ago

dbhynds commented 3 years ago

This PR is admittedly massive, and there's not really any way around it. I'll do my best to categorize the changes I've made:

Code coverage is currently at 52%. Not great, but it's a lot better than 0. I also ported over our certification tests from PBQ and (with not a small amount of struggling) managed to get the tests implemented for IMS LTI 1.3 Certification.

There are several areas of the code marked with @todo, mostly revolving around testing. If I have time later this sprint, I'll come back to these, but I wanted to get something out there first.

I have a local branch on PBQ that references this one to verify at the very least that nothing I did here breaks anything over there. https://github.com/packbackbooks/questions/tree/lti-13

dbhynds commented 3 years ago

Now that we're actually validating the Nonce, it's causing our LTI 1.3 cert suite to fail. Looking into why exactly.

dbhynds commented 3 years ago

Alright, everything passes. I also tested manual launching with LTI 1.3