packbackbooks / lti-1-3-php-library

A library used for building IMS-certified LTI 1.3 tool providers in PHP.
Apache License 2.0
39 stars 25 forks source link

Add src field to iframe resource #109

Closed cmcfadden closed 1 year ago

cmcfadden commented 1 year ago

Summary of Changes

Discussed in #108, Canvas expects a src parameter on iframe deeplink resources. Even if the URL of the deeplink is set, nothing will be rendered if src is not present. This PR adds the src parameter to the existing height and width values.

Testing

Tests were added. I also ran this in a dev instance against Canvas to verify the functionality is behaving as expected.