PODB-266 Adds logging of a request/response we send/receive when syncing an LTI 1.3 grade

packbackbooks / lti-1-3-php-library

A library used for building IMS-certified LTI 1.3 tool providers in PHP.

Apache License 2.0

39 stars 25 forks source link

PODB-266 Adds logging of a request/response we send/receive when syncing an LTI 1.3 grade #31

Closed zlayaAvocado closed 3 years ago

zlayaAvocado commented 3 years ago

Summary of Changes

Adds logging of a request/response we send/receive when syncing an LTI 1.3 grade. Since logging on the Grade model might not be accurate, the only way to have true data is to log a request and response.

Testing

Synced a grade and saw the logs pop up.

[ ] I have added automated tests for my changes

mattwright commented 3 years ago

Why is this information being written to the error log?

zlayaAvocado commented 3 years ago

Why is this information being written to the error log?

I am not sure if there are any proper ways of doing info logs here. Do you have any suggestions?

Meanwhile, I will make an update to disable the logging by default.

mattwright commented 3 years ago

Meanwhile, I will make an update to disable the logging by default.

That seems great if this is behind a debugging/info flag of some sort -- just thought it was odd if it was always going to be logging these for every request in production. Thanks!

zlayaAvocado commented 3 years ago

Meanwhile, I will make an update to disable the logging by default.

That seems great if this is behind a debugging/info flag of some sort -- just thought it was odd if it was always going to be logging these for every request in production. Thanks!

I agree, sorry for the trouble!