packbackbooks / lti-1-3-php-library

A library used for building IMS-certified LTI 1.3 tool providers in PHP.
Apache License 2.0
39 stars 25 forks source link

PODB-563 Move type and method constants to ServiceRequest #61

Closed dbhynds closed 2 years ago

dbhynds commented 2 years ago

Summary of Changes

This PR moves the request type and method constants to the ServiceRequest object instead of the LtiServiceConnector. I think it makes more sense for them to live here, since they're describing the request itself, not anything about the connector.

This also fixes a bug where we were treating every request like an auth request in the logs.

Testing

Here's the branch: https://github.com/packbackbooks/questions/pull/6533